powerpc/40x: Use {upper,lower}_32_bits for msi_phys
authorJosh Boyer <jwboyer@gmail.com>
Fri, 4 May 2012 00:13:13 +0000 (20:13 -0400)
committerJosh Boyer <jwboyer@gmail.com>
Fri, 4 May 2012 00:13:13 +0000 (20:13 -0400)
Fix a build error when -Werror is set:
arch/powerpc/sysdev/ppc4xx_msi.c: In function ‘ppc4xx_setup_pcieh_hw’:
arch/powerpc/sysdev/ppc4xx_msi.c:178:2: error: right shift count >= width of type [-Werror]

Signed-off-by: Josh Boyer <jwboyer@gmail.com>
arch/powerpc/sysdev/ppc4xx_msi.c

index cc17f591bd6626c6fcc16bb887c64cc2b8ba7ab6..82c6702dcbab7a756a7ed53de6c7638348f15c97 100644 (file)
@@ -175,8 +175,8 @@ static int ppc4xx_setup_pcieh_hw(struct platform_device *dev,
        msi_virt = dma_alloc_coherent(&dev->dev, 64, &msi_phys, GFP_KERNEL);
        if (!msi_virt)
                return -ENOMEM;
-       msi->msi_addr_hi = (u32)(msi_phys >> 32);
-       msi->msi_addr_lo = (u32)(msi_phys & 0xffffffff);
+       msi->msi_addr_hi = upper_32_bits(msi_phys);
+       msi->msi_addr_lo = lower_32_bits(msi_phys & 0xffffffff);
        dev_dbg(&dev->dev, "PCIE-MSI: msi address high 0x%x, low 0x%x\n",
                msi->msi_addr_hi, msi->msi_addr_lo);