ipw2x00: clean up a condition
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 9 Oct 2014 09:59:39 +0000 (12:59 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 27 Oct 2014 18:16:14 +0000 (14:16 -0400)
The original condition was "(PAGE_SIZE - len)" when "(len < PAGE_SIZE)"
is intended.

This condition is not really sufficient, but also not really needed...
If "len > PAGE_SIZE" then it we will print a warning message in dmesg
but there are no other effects.  Maybe we should just remove the
condition?

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ipw2x00/ipw2200.c

index edc344334a7547006901de8e3b5dcd79db66c0a9..67cad9b05ad821fc720da095aced2a9fe72202b8 100644 (file)
@@ -1363,7 +1363,7 @@ static ssize_t show_cmd_log(struct device *d,
        if (!priv->cmdlog)
                return 0;
        for (i = (priv->cmdlog_pos + 1) % priv->cmdlog_len;
-            (i != priv->cmdlog_pos) && (PAGE_SIZE - len);
+            (i != priv->cmdlog_pos) && (len < PAGE_SIZE);
             i = (i + 1) % priv->cmdlog_len) {
                len +=
                    snprintf(buf + len, PAGE_SIZE - len,