amdkfd: fix some error handling in ioctl
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 25 Nov 2014 10:21:30 +0000 (13:21 +0300)
committerOded Gabbay <oded.gabbay@amd.com>
Tue, 25 Nov 2014 10:21:30 +0000 (13:21 +0300)
There is a typo here so the errors from kfd_bind_process_to_device()
are not detected.

Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

index 3b3fce7331368efe8a2cf461f074d8404c31bdfb..102cd36799b129d4680567bb3de912a73b3070a9 100644 (file)
@@ -242,7 +242,7 @@ static long kfd_ioctl_create_queue(struct file *filep, struct kfd_process *p,
        mutex_lock(&p->mutex);
 
        pdd = kfd_bind_process_to_device(dev, p);
-       if (IS_ERR(pdd) < 0) {
+       if (IS_ERR(pdd)) {
                err = PTR_ERR(pdd);
                goto err_bind_process;
        }
@@ -389,7 +389,7 @@ static long kfd_ioctl_set_memory_policy(struct file *filep,
        mutex_lock(&p->mutex);
 
        pdd = kfd_bind_process_to_device(dev, p);
-       if (IS_ERR(pdd) < 0) {
+       if (IS_ERR(pdd)) {
                err = PTR_ERR(pdd);
                goto out;
        }