of: unittest: Add option string test case with longer path
authorBrian Norris <computersforpeace@gmail.com>
Tue, 17 Mar 2015 19:30:32 +0000 (12:30 -0700)
committerRob Herring <robh@kernel.org>
Thu, 19 Mar 2015 13:39:44 +0000 (08:39 -0500)
There were regressions seen with commit 106937e8ccdc ("of: fix handling
of '/' in options for of_find_node_by_path()"), where we couldn't handle
extra '/' before the ':'. Let's test for this now.

Confirmed that this test fails without the previous patch and passes
when patched. All other tests pass.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/unittest.c

index aba8946cac46dddd171aed6ddf6e35f58be152b7..52c45c7df07ff6623c7fb7656961f8bdcf804da3 100644 (file)
@@ -97,6 +97,11 @@ static void __init of_selftest_find_node_by_name(void)
                 "option path test, subcase #1 failed\n");
        of_node_put(np);
 
+       np = of_find_node_opts_by_path("/testcase-data/testcase-device1:test/option", &options);
+       selftest(np && !strcmp("test/option", options),
+                "option path test, subcase #2 failed\n");
+       of_node_put(np);
+
        np = of_find_node_opts_by_path("/testcase-data:testoption", NULL);
        selftest(np, "NULL option path test failed\n");
        of_node_put(np);