[PATCH] r8169: Fix iteration variable sign
authorFrancois Romieu <romieu@fr.zoreil.com>
Wed, 29 Nov 2006 21:21:33 +0000 (22:21 +0100)
committerLinus Torvalds <torvalds@woody.osdl.org>
Wed, 29 Nov 2006 21:45:07 +0000 (13:45 -0800)
This changes the type of variable "i" in rtl8169_init_one()
from "unsigned int" to "int". "i" is checked for < 0 later,
which can never happen for "unsigned". This results in broken
error handling.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/net/r8169.c

index 27f90b2139c0cc0db75c9bb10020085cca068527..b977ed85ff391c96dd122a45c8d2772b602b5fda 100644 (file)
@@ -1473,8 +1473,8 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        struct rtl8169_private *tp;
        struct net_device *dev;
        void __iomem *ioaddr;
-       unsigned int i, pm_cap;
-       int rc;
+       unsigned int pm_cap;
+       int i, rc;
 
        if (netif_msg_drv(&debug)) {
                printk(KERN_INFO "%s Gigabit Ethernet driver %s loaded\n",