atm: Use ether_addr_copy
authorJoe Perches <joe@perches.com>
Mon, 20 Jan 2014 17:52:16 +0000 (09:52 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Jan 2014 02:13:04 +0000 (18:13 -0800)
Use ether_addr_copy instead of memcpy(a, b, ETH_ALEN) to
save some cycles on arm and powerpc.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/atm/lec.c
net/atm/mpc.c

index f23916be18fb2416b951019b45c99df943cc390c..0b73ae9a1040729ea6556ab1652b74b031e81bc9 100644 (file)
@@ -521,7 +521,7 @@ send_to_lecd(struct lec_priv *priv, atmlec_msg_type type,
        if (data != NULL)
                mesg->sizeoftlvs = data->len;
        if (mac_addr)
-               memcpy(&mesg->content.normal.mac_addr, mac_addr, ETH_ALEN);
+               ether_addr_copy(&mesg->content.normal.mac_addr, mac_addr);
        else
                mesg->content.normal.targetless_le_arp = 1;
        if (atm_addr)
@@ -1565,7 +1565,7 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
                pr_info("LEC: Arp entry kmalloc failed\n");
                return NULL;
        }
-       memcpy(to_return->mac_addr, mac_addr, ETH_ALEN);
+       ether_addr_copy(to_return->mac_addr, mac_addr);
        INIT_HLIST_NODE(&to_return->next);
        setup_timer(&to_return->timer, lec_arp_expire_arp,
                        (unsigned long)to_return);
@@ -1887,7 +1887,8 @@ lec_arp_update(struct lec_priv *priv, const unsigned char *mac_addr,
                                        entry = tmp;
                                } else {
                                        entry->status = ESI_FORWARD_DIRECT;
-                                       memcpy(entry->mac_addr, mac_addr, ETH_ALEN);
+                                       ether_addr_copy(entry->mac_addr,
+                                                       mac_addr);
                                        entry->last_used = jiffies;
                                        lec_arp_add(priv, entry);
                                }
@@ -2263,7 +2264,7 @@ lec_arp_check_empties(struct lec_priv *priv,
                                  &priv->lec_arp_empty_ones, next) {
                if (vcc == entry->vcc) {
                        del_timer(&entry->timer);
-                       memcpy(entry->mac_addr, src, ETH_ALEN);
+                       ether_addr_copy(entry->mac_addr, src);
                        entry->status = ESI_FORWARD_DIRECT;
                        entry->last_used = jiffies;
                        /* We might have got an entry */
index 3af12755cd04851147b8e4661fd312e29abd0691..b71ff6b234f2bb1c6d97915eb5a4fb6ab4d1851d 100644 (file)
@@ -478,7 +478,7 @@ static const uint8_t *copy_macs(struct mpoa_client *mpc,
                        return NULL;
                }
        }
-       memcpy(mpc->mps_macs, router_mac, ETH_ALEN);
+       ether_addr_copy(mpc->mps_macs, router_mac);
        tlvs += 20; if (device_type == MPS_AND_MPC) tlvs += 20;
        if (mps_macs > 0)
                memcpy(mpc->mps_macs, tlvs, mps_macs*ETH_ALEN);