tools/perf/build: Improve the 'stackprotector' feature test
authorIngo Molnar <mingo@kernel.org>
Thu, 10 Oct 2013 07:06:21 +0000 (09:06 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 14 Oct 2013 13:29:15 +0000 (10:29 -0300)
Namhyung Kim noticed that the stackprotector testcase was incomplete:

  > The flag being checked should be -"W"stack-protector instead of
  > -"f"stack-protector.  And the gcc manpage says that -Wstack-protector is
  > only active when -fstack-protector is active.  So the end result should
  > look like
  >
  >         $(BUILD) -Werror -fstack-protector -Wstack-protector

Add -Wstack-protector.

Reported-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/config/feature-checks/Makefile

index 2eb83467cca2d3fb51d936b0d14a5048a0548167..c70d23ecb64e69b4593b4b31872d09b505608808 100644 (file)
@@ -45,7 +45,7 @@ test-stackprotector-all:
        $(BUILD) -Werror -fstack-protector-all
 
 test-stackprotector:
-       $(BUILD) -Werror -fstack-protector
+       $(BUILD) -Werror -fstack-protector -Wstack-protector
 
 test-fortify-source:
        $(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2