drivers/gpu/drm/i915/intel_dp_mst.c

   1 /*
   2  * Copyright © 2008 Intel Corporation
   3  *             2014 Red Hat Inc.
   4  *
   5  * Permission is hereby granted, free of charge, to any person obtaining a
   6  * copy of this software and associated documentation files (the "Software"),
   7  * to deal in the Software without restriction, including without limitation
   8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   9  * and/or sell copies of the Software, and to permit persons to whom the
  10  * Software is furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice (including the next
  13  * paragraph) shall be included in all copies or substantial portions of the
  14  * Software.
  15  *
  16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  22  * IN THE SOFTWARE.
  23  *
  24  */
  25
  26 #include <drm/drmP.h>
  27 #include "i915_drv.h"
  28 #include "intel_drv.h"
  29 #include <drm/drm_atomic_helper.h>
  30 #include <drm/drm_crtc_helper.h>
  31 #include <drm/drm_edid.h>
  32
  33 static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
  34                                         struct intel_crtc_state *pipe_config)
  35 {
  36         struct drm_device *dev = encoder->base.dev;
  37         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
  38         struct intel_digital_port *intel_dig_port = intel_mst->primary;
  39         struct intel_dp *intel_dp = &intel_dig_port->dp;
  40         struct drm_atomic_state *state;
  41         int bpp, i;
  42         int lane_count, slots, rate;
  43         struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  44         struct drm_connector *drm_connector;
  45         struct intel_connector *connector, *found = NULL;
  46         struct drm_connector_state *connector_state;
  47         int mst_pbn;
  48
  49         pipe_config->dp_encoder_is_mst = true;
  50         pipe_config->has_pch_encoder = false;
  51         pipe_config->has_dp_encoder = true;
  52         bpp = 24;
  53         /*
  54          * for MST we always configure max link bw - the spec doesn't
  55          * seem to suggest we should do otherwise.
  56          */
  57         lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
  58
  59         rate = intel_dp_max_link_rate(intel_dp);
  60
  61         if (intel_dp->num_sink_rates) {
  62                 intel_dp->link_bw = 0;
  63                 intel_dp->rate_select = intel_dp_rate_select(intel_dp, rate);
  64         } else {
  65                 intel_dp->link_bw = drm_dp_link_rate_to_bw_code(rate);
  66                 intel_dp->rate_select = 0;
  67         }
  68
  69         intel_dp->lane_count = lane_count;
  70
  71         pipe_config->pipe_bpp = 24;
  72         pipe_config->port_clock = rate;
  73
  74         state = pipe_config->base.state;
  75
  76         for_each_connector_in_state(state, drm_connector, connector_state, i) {
  77                 connector = to_intel_connector(drm_connector);
  78
  79                 if (connector_state->best_encoder == &encoder->base) {
  80                         found = connector;
  81                         break;
  82                 }
  83         }
  84
  85         if (!found) {
  86                 DRM_ERROR("can't find connector\n");
  87                 return false;
  88         }
  89
  90         mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->clock, bpp);
  91
  92         pipe_config->pbn = mst_pbn;
  93         slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);
  94
  95         intel_link_compute_m_n(bpp, lane_count,
  96                                adjusted_mode->crtc_clock,
  97                                pipe_config->port_clock,
  98                                &pipe_config->dp_m_n);
  99
 100         pipe_config->dp_m_n.tu = slots;
 101
 102         if (IS_HASWELL(dev) || IS_BROADWELL(dev))
 103                 hsw_dp_set_ddi_pll_sel(pipe_config);
 104
 105         return true;
 106
 107 }
 108
 109 static void intel_mst_disable_dp(struct intel_encoder *encoder)
 110 {
 111         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 112         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 113         struct intel_dp *intel_dp = &intel_dig_port->dp;
 114         int ret;
 115
 116         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 117
 118         drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, intel_mst->port);
 119
 120         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
 121         if (ret) {
 122                 DRM_ERROR("failed to update payload %d\n", ret);
 123         }
 124 }
 125
 126 static void intel_mst_post_disable_dp(struct intel_encoder *encoder)
 127 {
 128         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 129         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 130         struct intel_dp *intel_dp = &intel_dig_port->dp;
 131
 132         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 133
 134         /* this can fail */
 135         drm_dp_check_act_status(&intel_dp->mst_mgr);
 136         /* and this can also fail */
 137         drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 138
 139         drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, intel_mst->port);
 140
 141         intel_dp->active_mst_links--;
 142         intel_mst->port = NULL;
 143         if (intel_dp->active_mst_links == 0) {
 144                 intel_dig_port->base.post_disable(&intel_dig_port->base);
 145                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
 146         }
 147 }
 148
 149 static void intel_mst_pre_enable_dp(struct intel_encoder *encoder)
 150 {
 151         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 152         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 153         struct intel_dp *intel_dp = &intel_dig_port->dp;
 154         struct drm_device *dev = encoder->base.dev;
 155         struct drm_i915_private *dev_priv = dev->dev_private;
 156         enum port port = intel_dig_port->port;
 157         int ret;
 158         uint32_t temp;
 159         struct intel_connector *found = NULL, *connector;
 160         int slots;
 161         struct drm_crtc *crtc = encoder->base.crtc;
 162         struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
 163
 164         for_each_intel_connector(dev, connector) {
 165                 if (connector->base.state->best_encoder == &encoder->base) {
 166                         found = connector;
 167                         break;
 168                 }
 169         }
 170
 171         if (!found) {
 172                 DRM_ERROR("can't find connector\n");
 173                 return;
 174         }
 175
 176         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 177         intel_mst->port = found->port;
 178
 179         if (intel_dp->active_mst_links == 0) {
 180                 enum port port = intel_ddi_get_encoder_port(encoder);
 181
 182                 /* FIXME: add support for SKL */
 183                 if (INTEL_INFO(dev)->gen < 9)
 184                         I915_WRITE(PORT_CLK_SEL(port),
 185                                    intel_crtc->config->ddi_pll_sel);
 186
 187                 intel_ddi_init_dp_buf_reg(&intel_dig_port->base);
 188
 189                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
 190
 191
 192                 intel_dp_start_link_train(intel_dp);
 193                 intel_dp_complete_link_train(intel_dp);
 194                 intel_dp_stop_link_train(intel_dp);
 195         }
 196
 197         ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
 198                                        intel_mst->port,
 199                                        intel_crtc->config->pbn, &slots);
 200         if (ret == false) {
 201                 DRM_ERROR("failed to allocate vcpi\n");
 202                 return;
 203         }
 204
 205
 206         intel_dp->active_mst_links++;
 207         temp = I915_READ(DP_TP_STATUS(port));
 208         I915_WRITE(DP_TP_STATUS(port), temp);
 209
 210         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
 211 }
 212
 213 static void intel_mst_enable_dp(struct intel_encoder *encoder)
 214 {
 215         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 216         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 217         struct intel_dp *intel_dp = &intel_dig_port->dp;
 218         struct drm_device *dev = intel_dig_port->base.base.dev;
 219         struct drm_i915_private *dev_priv = dev->dev_private;
 220         enum port port = intel_dig_port->port;
 221         int ret;
 222
 223         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 224
 225         if (wait_for((I915_READ(DP_TP_STATUS(port)) & DP_TP_STATUS_ACT_SENT),
 226                      1))
 227                 DRM_ERROR("Timed out waiting for ACT sent\n");
 228
 229         ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
 230
 231         ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 232 }
 233
 234 static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
 235                                       enum pipe *pipe)
 236 {
 237         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 238         *pipe = intel_mst->pipe;
 239         if (intel_mst->port)
 240                 return true;
 241         return false;
 242 }
 243
 244 static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
 245                                         struct intel_crtc_state *pipe_config)
 246 {
 247         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 248         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 249         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
 250         struct drm_device *dev = encoder->base.dev;
 251         struct drm_i915_private *dev_priv = dev->dev_private;
 252         enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
 253         u32 temp, flags = 0;
 254
 255         pipe_config->has_dp_encoder = true;
 256
 257         temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
 258         if (temp & TRANS_DDI_PHSYNC)
 259                 flags |= DRM_MODE_FLAG_PHSYNC;
 260         else
 261                 flags |= DRM_MODE_FLAG_NHSYNC;
 262         if (temp & TRANS_DDI_PVSYNC)
 263                 flags |= DRM_MODE_FLAG_PVSYNC;
 264         else
 265                 flags |= DRM_MODE_FLAG_NVSYNC;
 266
 267         switch (temp & TRANS_DDI_BPC_MASK) {
 268         case TRANS_DDI_BPC_6:
 269                 pipe_config->pipe_bpp = 18;
 270                 break;
 271         case TRANS_DDI_BPC_8:
 272                 pipe_config->pipe_bpp = 24;
 273                 break;
 274         case TRANS_DDI_BPC_10:
 275                 pipe_config->pipe_bpp = 30;
 276                 break;
 277         case TRANS_DDI_BPC_12:
 278                 pipe_config->pipe_bpp = 36;
 279                 break;
 280         default:
 281                 break;
 282         }
 283         pipe_config->base.adjusted_mode.flags |= flags;
 284         intel_dp_get_m_n(crtc, pipe_config);
 285
 286         intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
 287 }
 288
 289 static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
 290 {
 291         struct intel_connector *intel_connector = to_intel_connector(connector);
 292         struct intel_dp *intel_dp = intel_connector->mst_port;
 293         struct edid *edid;
 294         int ret;
 295
 296         edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
 297         if (!edid)
 298                 return 0;
 299
 300         ret = intel_connector_update_modes(connector, edid);
 301         kfree(edid);
 302
 303         return ret;
 304 }
 305
 306 static enum drm_connector_status
 307 intel_dp_mst_detect(struct drm_connector *connector, bool force)
 308 {
 309         struct intel_connector *intel_connector = to_intel_connector(connector);
 310         struct intel_dp *intel_dp = intel_connector->mst_port;
 311
 312         return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
 313 }
 314
 315 static int
 316 intel_dp_mst_set_property(struct drm_connector *connector,
 317                           struct drm_property *property,
 318                           uint64_t val)
 319 {
 320         return 0;
 321 }
 322
 323 static void
 324 intel_dp_mst_connector_destroy(struct drm_connector *connector)
 325 {
 326         struct intel_connector *intel_connector = to_intel_connector(connector);
 327
 328         if (!IS_ERR_OR_NULL(intel_connector->edid))
 329                 kfree(intel_connector->edid);
 330
 331         drm_connector_cleanup(connector);
 332         kfree(connector);
 333 }
 334
 335 static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
 336         .dpms = drm_atomic_helper_connector_dpms,
 337         .detect = intel_dp_mst_detect,
 338         .fill_modes = drm_helper_probe_single_connector_modes,
 339         .set_property = intel_dp_mst_set_property,
 340         .atomic_get_property = intel_connector_atomic_get_property,
 341         .destroy = intel_dp_mst_connector_destroy,
 342         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 343         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 344 };
 345
 346 static int intel_dp_mst_get_modes(struct drm_connector *connector)
 347 {
 348         return intel_dp_mst_get_ddc_modes(connector);
 349 }
 350
 351 static enum drm_mode_status
 352 intel_dp_mst_mode_valid(struct drm_connector *connector,
 353                         struct drm_display_mode *mode)
 354 {
 355         /* TODO - validate mode against available PBN for link */
 356         if (mode->clock < 10000)
 357                 return MODE_CLOCK_LOW;
 358
 359         if (mode->flags & DRM_MODE_FLAG_DBLCLK)
 360                 return MODE_H_ILLEGAL;
 361
 362         return MODE_OK;
 363 }
 364
 365 static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
 366                                                          struct drm_connector_state *state)
 367 {
 368         struct intel_connector *intel_connector = to_intel_connector(connector);
 369         struct intel_dp *intel_dp = intel_connector->mst_port;
 370         struct intel_crtc *crtc = to_intel_crtc(state->crtc);
 371
 372         return &intel_dp->mst_encoders[crtc->pipe]->base.base;
 373 }
 374
 375 static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
 376 {
 377         struct intel_connector *intel_connector = to_intel_connector(connector);
 378         struct intel_dp *intel_dp = intel_connector->mst_port;
 379         return &intel_dp->mst_encoders[0]->base.base;
 380 }
 381
 382 static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
 383         .get_modes = intel_dp_mst_get_modes,
 384         .mode_valid = intel_dp_mst_mode_valid,
 385         .atomic_best_encoder = intel_mst_atomic_best_encoder,
 386         .best_encoder = intel_mst_best_encoder,
 387 };
 388
 389 static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
 390 {
 391         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
 392
 393         drm_encoder_cleanup(encoder);
 394         kfree(intel_mst);
 395 }
 396
 397 static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
 398         .destroy = intel_dp_mst_encoder_destroy,
 399 };
 400
 401 static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
 402 {
 403         if (connector->encoder) {
 404                 enum pipe pipe;
 405                 if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
 406                         return false;
 407                 return true;
 408         }
 409         return false;
 410 }
 411
 412 static void intel_connector_add_to_fbdev(struct intel_connector *connector)
 413 {
 414 #ifdef CONFIG_DRM_FBDEV_EMULATION
 415         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 416         drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper, &connector->base);
 417 #endif
 418 }
 419
 420 static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
 421 {
 422 #ifdef CONFIG_DRM_FBDEV_EMULATION
 423         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 424         drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper, &connector->base);
 425 #endif
 426 }
 427
 428 static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
 429 {
 430         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 431         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 432         struct drm_device *dev = intel_dig_port->base.base.dev;
 433         struct intel_connector *intel_connector;
 434         struct drm_connector *connector;
 435         int i;
 436
 437         intel_connector = intel_connector_alloc();
 438         if (!intel_connector)
 439                 return NULL;
 440
 441         connector = &intel_connector->base;
 442         drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
 443         drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
 444
 445         intel_connector->unregister = intel_connector_unregister;
 446         intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
 447         intel_connector->mst_port = intel_dp;
 448         intel_connector->port = port;
 449
 450         for (i = PIPE_A; i <= PIPE_C; i++) {
 451                 drm_mode_connector_attach_encoder(&intel_connector->base,
 452                                                   &intel_dp->mst_encoders[i]->base.base);
 453         }
 454         intel_dp_add_properties(intel_dp, connector);
 455
 456         drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
 457         drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);
 458
 459         drm_mode_connector_set_path_property(connector, pathprop);
 460         drm_modeset_lock_all(dev);
 461         intel_connector_add_to_fbdev(intel_connector);
 462         drm_modeset_unlock_all(dev);
 463         drm_connector_register(&intel_connector->base);
 464         return connector;
 465 }
 466
 467 static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
 468                                            struct drm_connector *connector)
 469 {
 470         struct intel_connector *intel_connector = to_intel_connector(connector);
 471         struct drm_device *dev = connector->dev;
 472
 473         /* need to nuke the connector */
 474         drm_modeset_lock_all(dev);
 475         if (connector->state->crtc) {
 476                 struct drm_mode_set set;
 477                 int ret;
 478
 479                 memset(&set, 0, sizeof(set));
 480                 set.crtc = connector->state->crtc,
 481
 482                 ret = drm_atomic_helper_set_config(&set);
 483
 484                 WARN(ret, "Disabling mst crtc failed with %i\n", ret);
 485         }
 486         drm_modeset_unlock_all(dev);
 487
 488         intel_connector->unregister(intel_connector);
 489
 490         drm_modeset_lock_all(dev);
 491         intel_connector_remove_from_fbdev(intel_connector);
 492         drm_connector_cleanup(connector);
 493         drm_modeset_unlock_all(dev);
 494
 495         kfree(intel_connector);
 496         DRM_DEBUG_KMS("\n");
 497 }
 498
 499 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
 500 {
 501         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 502         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 503         struct drm_device *dev = intel_dig_port->base.base.dev;
 504
 505         drm_kms_helper_hotplug_event(dev);
 506 }
 507
 508 static struct drm_dp_mst_topology_cbs mst_cbs = {
 509         .add_connector = intel_dp_add_mst_connector,
 510         .destroy_connector = intel_dp_destroy_mst_connector,
 511         .hotplug = intel_dp_mst_hotplug,
 512 };
 513
 514 static struct intel_dp_mst_encoder *
 515 intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
 516 {
 517         struct intel_dp_mst_encoder *intel_mst;
 518         struct intel_encoder *intel_encoder;
 519         struct drm_device *dev = intel_dig_port->base.base.dev;
 520
 521         intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
 522
 523         if (!intel_mst)
 524                 return NULL;
 525
 526         intel_mst->pipe = pipe;
 527         intel_encoder = &intel_mst->base;
 528         intel_mst->primary = intel_dig_port;
 529
 530         drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
 531                          DRM_MODE_ENCODER_DPMST);
 532
 533         intel_encoder->type = INTEL_OUTPUT_DP_MST;
 534         intel_encoder->crtc_mask = 0x7;
 535         intel_encoder->cloneable = 0;
 536
 537         intel_encoder->compute_config = intel_dp_mst_compute_config;
 538         intel_encoder->disable = intel_mst_disable_dp;
 539         intel_encoder->post_disable = intel_mst_post_disable_dp;
 540         intel_encoder->pre_enable = intel_mst_pre_enable_dp;
 541         intel_encoder->enable = intel_mst_enable_dp;
 542         intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
 543         intel_encoder->get_config = intel_dp_mst_enc_get_config;
 544
 545         return intel_mst;
 546
 547 }
 548
 549 static bool
 550 intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
 551 {
 552         int i;
 553         struct intel_dp *intel_dp = &intel_dig_port->dp;
 554
 555         for (i = PIPE_A; i <= PIPE_C; i++)
 556                 intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
 557         return true;
 558 }
 559
 560 int
 561 intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
 562 {
 563         struct intel_dp *intel_dp = &intel_dig_port->dp;
 564         struct drm_device *dev = intel_dig_port->base.base.dev;
 565         int ret;
 566
 567         intel_dp->can_mst = true;
 568         intel_dp->mst_mgr.cbs = &mst_cbs;
 569
 570         /* create encoders */
 571         intel_dp_create_fake_mst_encoders(intel_dig_port);
 572         ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev->dev, &intel_dp->aux, 16, 3, conn_base_id);
 573         if (ret) {
 574                 intel_dp->can_mst = false;
 575                 return ret;
 576         }
 577         return 0;
 578 }
 579
 580 void
 581 intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
 582 {
 583         struct intel_dp *intel_dp = &intel_dig_port->dp;
 584
 585         if (!intel_dp->can_mst)
 586                 return;
 587
 588         drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
 589         /* encoders will get killed by normal cleanup */
 590 }