slub: Do not hold slub_lock when calling sysfs_slab_add()
authorChristoph Lameter <cl@linux.com>
Tue, 17 Jan 2012 15:27:31 +0000 (09:27 -0600)
committerPekka Enberg <penberg@kernel.org>
Mon, 6 Feb 2012 10:24:13 +0000 (12:24 +0200)
commit66c4c35c6bc5a1a452b024cf0364635b28fd94e4
tree75fa5528d28fdedde489e4d9ebc4a961aeecd6f0
parent0ad9500e16fe24aa55809a2b00e0d2d0e658fc71
slub: Do not hold slub_lock when calling sysfs_slab_add()

sysfs_slab_add() calls various sysfs functions that actually may
end up in userspace doing all sorts of things.

Release the slub_lock after adding the kmem_cache structure to the list.
At that point the address of the kmem_cache is not known so we are
guaranteed exlusive access to the following modifications to the
kmem_cache structure.

If the sysfs_slab_add fails then reacquire the slub_lock to
remove the kmem_cache structure from the list.

Cc: <stable@vger.kernel.org> # 3.3+
Reported-by: Sasha Levin <levinsasha928@gmail.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
mm/slub.c