mm: Initialize error in shmem_file_aio_read()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Sun, 13 Apr 2014 18:46:22 +0000 (20:46 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 13 Apr 2014 21:10:26 +0000 (14:10 -0700)
Some versions of gcc even warn about it:

  mm/shmem.c: In function ‘shmem_file_aio_read’:
  mm/shmem.c:1414: warning: ‘error’ may be used uninitialized in this function

If the loop is aborted during the first iteration by one of the two
first break statements, error will be uninitialized.

Introduced by commit 6e58e79db8a1 ("introduce copy_page_to_iter, kill
loop over iovec in generic_file_aio_read()").

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/shmem.c

index 8f1a95406bae6a61b20be247b50603cdedc30398..9f70e02111c6adcd090d8372ae0405b0f22b9abc 100644 (file)
@@ -1411,7 +1411,7 @@ static ssize_t shmem_file_aio_read(struct kiocb *iocb,
        pgoff_t index;
        unsigned long offset;
        enum sgp_type sgp = SGP_READ;
-       int error;
+       int error = 0;
        ssize_t retval;
        size_t count;
        loff_t *ppos = &iocb->ki_pos;