atm: firestream: Use del_timer_sync() in teardown path
authorThomas Gleixner <tglx@linutronix.de>
Sun, 23 Mar 2014 15:09:28 +0000 (15:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Mar 2014 01:06:02 +0000 (21:06 -0400)
The device is about to vanish. So we need to make sure that the timer
is completely stopped and the callback is not running on another CPU.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>
Cc: atm <linux-atm-general@lists.sourceforge.net>
Cc: netdev <netdev@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/firestream.c

index f43e1c13b300af0e16ce7d7a7ef012c357be374b..82f2ae0d7cc488a337772aaf8d7a19b3373bcd94 100644 (file)
@@ -2000,7 +2000,7 @@ static void firestream_remove_one(struct pci_dev *pdev)
 
                fs_dprintk (FS_DEBUG_CLEANUP, "Freeing irq%d.\n", dev->irq);
                free_irq (dev->irq, dev);
-               del_timer (&dev->timer);
+               del_timer_sync (&dev->timer);
 
                atm_dev_deregister(dev->atm_dev);
                free_queue (dev, &dev->hp_txq);