drivers/rtc/rtc-pl03x.c: remove unnecessary amba_set_drvdata()
authorMichal Simek <michal.simek@xilinx.com>
Tue, 12 Nov 2013 23:11:00 +0000 (15:11 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 13 Nov 2013 03:09:31 +0000 (12:09 +0900)
Driver core clears the driver data to NULL after device_release or on
probe failure, so just remove it from here.

The relevant driver core change was commit 0998d0631001 ("device-core:
Ensure drvdata = NULL when no driver is bound").

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-pl030.c
drivers/rtc/rtc-pl031.c

index 22bacdbf9139dce42e82754ec9de7c061dea755e..a804f758ac6dd9684c14b1a1fd44219c2b3325e1 100644 (file)
@@ -153,8 +153,6 @@ static int pl030_remove(struct amba_device *dev)
 {
        struct pl030_rtc *rtc = amba_get_drvdata(dev);
 
-       amba_set_drvdata(dev, NULL);
-
        writel(0, rtc->base + RTC_CR);
 
        free_irq(dev->irq[0], rtc);
index e3b25712b6591906aff9633e98d5c82f4feba351..99181fff88fd6f4e3518a1e2b3c166b674b59305 100644 (file)
@@ -305,7 +305,6 @@ static int pl031_remove(struct amba_device *adev)
 {
        struct pl031_local *ldata = dev_get_drvdata(&adev->dev);
 
-       amba_set_drvdata(adev, NULL);
        free_irq(adev->irq[0], ldata);
        rtc_device_unregister(ldata->rtc);
        iounmap(ldata->base);
@@ -391,7 +390,6 @@ out_no_irq:
        rtc_device_unregister(ldata->rtc);
 out_no_rtc:
        iounmap(ldata->base);
-       amba_set_drvdata(adev, NULL);
 out_no_remap:
        kfree(ldata);
 out: