KVM: PPC: Book3S PR: Fix proto-VSID calculations
authorPaul Mackerras <paulus@samba.org>
Sat, 22 Jun 2013 07:13:32 +0000 (17:13 +1000)
committerAlexander Graf <agraf@suse.de>
Sun, 30 Jun 2013 01:33:21 +0000 (03:33 +0200)
This makes sure the calculation of the proto-VSIDs used by PR KVM
is done with 64-bit arithmetic.  Since vcpu3s->context_id[] is int,
when we do vcpu3s->context_id[0] << ESID_BITS the shift will be done
with 32-bit instructions, possibly leading to significant bits
getting lost, as the context id can be up to 524283 and ESID_BITS is
18.  To fix this we cast the context id to u64 before shifting.

Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
arch/powerpc/kvm/book3s_64_mmu_host.c

index 3a9a1aceb14f576e8201164343b7d2b220cf553a..2c6e7ee8be3472266a8ae2a717b9d695f704b5fe 100644 (file)
@@ -325,9 +325,9 @@ int kvmppc_mmu_init(struct kvm_vcpu *vcpu)
                return -1;
        vcpu3s->context_id[0] = err;
 
-       vcpu3s->proto_vsid_max = ((vcpu3s->context_id[0] + 1)
+       vcpu3s->proto_vsid_max = ((u64)(vcpu3s->context_id[0] + 1)
                                  << ESID_BITS) - 1;
-       vcpu3s->proto_vsid_first = vcpu3s->context_id[0] << ESID_BITS;
+       vcpu3s->proto_vsid_first = (u64)vcpu3s->context_id[0] << ESID_BITS;
        vcpu3s->proto_vsid_next = vcpu3s->proto_vsid_first;
 
        kvmppc_mmu_hpte_init(vcpu);