dmaengine: omap-dma: use cached CCR value when enabling DMA
authorRussell King <rmk+kernel@arm.linux.org.uk>
Wed, 6 Nov 2013 17:18:42 +0000 (17:18 +0000)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Thu, 3 Apr 2014 23:30:21 +0000 (00:30 +0100)
We don't need to read-modify-write the CCR register; we already know
what value it should contain at this point.  Use the cached CCR value
when setting the enable bit.

Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
drivers/dma/omap-dma.c

index 49b303296d7581f11e3acb547e5ddf820318c4af..b270aedf1d157407213d95320d1d9e48bb7ba07c 100644 (file)
@@ -181,7 +181,6 @@ static void omap_dma_clear_csr(struct omap_chan *c)
 static void omap_dma_start(struct omap_chan *c, struct omap_desc *d)
 {
        struct omap_dmadev *od = to_omap_dma_dev(c->vc.chan.device);
-       uint32_t val;
 
        if (__dma_omap15xx(od->plat->dma_attr))
                c->plat->dma_write(0, CPC, c->dma_ch);
@@ -193,9 +192,8 @@ static void omap_dma_start(struct omap_chan *c, struct omap_desc *d)
        /* Enable interrupts */
        c->plat->dma_write(d->cicr, CICR, c->dma_ch);
 
-       val = c->plat->dma_read(CCR, c->dma_ch);
-       val |= CCR_ENABLE;
-       c->plat->dma_write(val, CCR, c->dma_ch);
+       /* Enable channel */
+       c->plat->dma_write(d->ccr | CCR_ENABLE, CCR, c->dma_ch);
 }
 
 static void omap_dma_stop(struct omap_chan *c)