ext4: fix SEEK_HOLE/SEEK_DATA for blocksize < pagesize
authorJan Kara <jack@suse.cz>
Sat, 5 Aug 2017 21:43:24 +0000 (17:43 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 5 Aug 2017 21:43:24 +0000 (17:43 -0400)
commitfcf5ea10992fbac3c7473a1db33d56a139333cd1
tree6d34847e81c3b949606546a24627ae82a422b50c
parente45105772db41c5318b2a7ec1c420183183414e3
ext4: fix SEEK_HOLE/SEEK_DATA for blocksize < pagesize

ext4_find_unwritten_pgoff() does not properly handle a situation when
starting index is in the middle of a page and blocksize < pagesize. The
following command shows the bug on filesystem with 1k blocksize:

  xfs_io -f -c "falloc 0 4k" \
            -c "pwrite 1k 1k" \
            -c "pwrite 3k 1k" \
            -c "seek -a -r 0" foo

In this example, neither lseek(fd, 1024, SEEK_HOLE) nor lseek(fd, 2048,
SEEK_DATA) will return the correct result.

Fix the problem by neglecting buffers in a page before starting offset.

Reported-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
CC: stable@vger.kernel.org # 3.8+
fs/ext4/file.c