i2c: dev: prevent ZERO_SIZE_PTR deref in i2cdev_ioctl_rdwr()
authorAlexander Popov <alex.popov@linux.com>
Thu, 19 Apr 2018 12:29:22 +0000 (15:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 May 2018 08:12:28 +0000 (10:12 +0200)
commitc1de578f80c66cabccf0b6d24d33ec1929044674
tree4f8086ababb8f755ded1ca1334e7a08fe4ae5455
parentf289a74702070a54ddda0dae589cf7db80e0a038
i2c: dev: prevent ZERO_SIZE_PTR deref in i2cdev_ioctl_rdwr()

commit 23a27722b5292ef0b27403c87a109feea8296a5c upstream.

i2cdev_ioctl_rdwr() allocates i2c_msg.buf using memdup_user(), which
returns ZERO_SIZE_PTR if i2c_msg.len is zero.

Currently i2cdev_ioctl_rdwr() always dereferences the buf pointer in case
of I2C_M_RD | I2C_M_RECV_LEN transfer. That causes a kernel oops in
case of zero len.

Let's check the len against zero before dereferencing buf pointer.

This issue was triggered by syzkaller.

Signed-off-by: Alexander Popov <alex.popov@linux.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
[wsa: use '< 1' instead of '!' for easier readability]
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/i2c-dev.c