From a14c44d82fcff280fd1138574d4480b2bdd40216 Mon Sep 17 00:00:00 2001 From: Tomas Winkler Date: Mon, 16 Sep 2013 23:44:45 +0300 Subject: [PATCH] mei: mei_cl_unlink: no need to loop over dev list we can call list_del_init regardless the client is linked or not it is always properly initialized Signed-off-by: Tomas Winkler Signed-off-by: Greg Kroah-Hartman --- drivers/misc/mei/client.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 2ab9d1613ffc..fbd319c506e6 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -318,7 +318,6 @@ int mei_cl_link(struct mei_cl *cl, int id) int mei_cl_unlink(struct mei_cl *cl) { struct mei_device *dev; - struct mei_cl *pos, *next; /* don't shout on error exit path */ if (!cl) @@ -330,14 +329,10 @@ int mei_cl_unlink(struct mei_cl *cl) dev = cl->dev; - list_for_each_entry_safe(pos, next, &dev->file_list, link) { - if (cl->host_client_id == pos->host_client_id) { - cl_dbg(dev, cl, "remove host client = %d, ME client = %d\n", - pos->host_client_id, pos->me_client_id); - list_del_init(&pos->link); - break; - } - } + cl_dbg(dev, cl, "unlink client"); + + list_del_init(&cl->link); + return 0; } -- 2.34.1