crypto: ixp4xx - Delete unnecessary checks before the function call "dma_pool_destroy"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 15 Nov 2015 15:51:21 +0000 (16:51 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 17 Nov 2015 14:00:41 +0000 (22:00 +0800)
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ixp4xx_crypto.c

index 8f279035328125de8f8c1216392e5674def45753..e52496a172d05e70893f48ff3cfca309e93db343 100644 (file)
@@ -510,10 +510,8 @@ npe_error:
        printk(KERN_ERR "%s not responding\n", npe_name(npe_c));
        ret = -EIO;
 err:
-       if (ctx_pool)
-               dma_pool_destroy(ctx_pool);
-       if (buffer_pool)
-               dma_pool_destroy(buffer_pool);
+       dma_pool_destroy(ctx_pool);
+       dma_pool_destroy(buffer_pool);
        npe_release(npe_c);
        return ret;
 }