bonding: convert arp_all_targets to use the new option API

This patch adds the necessary changes so arp_all_targets would use the
new bonding option API.

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 3903c87c8b8c725ea5e7acbb93d0d1b8e3d1c93b..103b6af30474f27c7ce755643f0e782e2543c6ef 100644 (file)
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -214,12 +214,6 @@ const struct bond_parm_tbl bond_lacp_tbl[] = {
 {      NULL,           -1},
 };
 
-const struct bond_parm_tbl arp_all_targets_tbl[] = {
-{      "any",                  BOND_ARP_TARGETS_ANY},
-{      "all",                  BOND_ARP_TARGETS_ALL},
-{      NULL,                   -1},
-};
-
 const struct bond_parm_tbl fail_over_mac_tbl[] = {
 {      "none",                 BOND_FOM_NONE},
 {      "active",               BOND_FOM_ACTIVE},
@@ -4231,13 +4225,15 @@ static int bond_check_params(struct bond_params *params)
 
        arp_all_targets_value = 0;
        if (arp_all_targets) {
-               arp_all_targets_value = bond_parse_parm(arp_all_targets,
-                                                       arp_all_targets_tbl);
-
-               if (arp_all_targets_value == -1) {
+               bond_opt_initstr(&newval, arp_all_targets);
+               valptr = bond_opt_parse(bond_opt_get(BOND_OPT_ARP_ALL_TARGETS),
+                                       &newval);
+               if (!valptr) {
                        pr_err("Error: invalid arp_all_targets_value \"%s\"\n",
                               arp_all_targets);
                        arp_all_targets_value = 0;
+               } else {
+                       arp_all_targets_value = valptr->value;
                }
        }
 

diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
index 588730c39748b10b93cbb44be6b0ab012104916b..ff1e3d3282e3843e16638259a94d9f3d1a486566 100644 (file)
--- a/drivers/net/bonding/bond_netlink.c
+++ b/drivers/net/bonding/bond_netlink.c
@@ -202,7 +202,8 @@ static int bond_changelink(struct net_device *bond_dev,
                int arp_all_targets =
                        nla_get_u32(data[IFLA_BOND_ARP_ALL_TARGETS]);
 
-               err = bond_option_arp_all_targets_set(bond, arp_all_targets);
+               bond_opt_initval(&newval, arp_all_targets);
+               err = __bond_opt_set(bond, BOND_OPT_ARP_ALL_TARGETS, &newval);
                if (err)
                        return err;
        }

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index eff68a0f71f0322792b15a8b3a85a639b04f73cb..e136e7525a023e88e99f23e43cd615e44c52bdc0 100644 (file)
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -53,6 +53,12 @@ static struct bond_opt_value bond_arp_validate_tbl[] = {
        { NULL,     -1,                       0},
 };
 
+static struct bond_opt_value bond_arp_all_targets_tbl[] = {
+       { "any", BOND_ARP_TARGETS_ANY, BOND_VALFLAG_DEFAULT},
+       { "all", BOND_ARP_TARGETS_ALL, 0},
+       { NULL,  -1,                   0},
+};
+
 static struct bond_option bond_opts[] = {
        [BOND_OPT_MODE] = {
                .id = BOND_OPT_MODE,
@@ -85,6 +91,13 @@ static struct bond_option bond_opts[] = {
                .values = bond_arp_validate_tbl,
                .set = bond_option_arp_validate_set
        },
+       [BOND_OPT_ARP_ALL_TARGETS] = {
+               .id = BOND_OPT_ARP_ALL_TARGETS,
+               .name = "arp_all_targets",
+               .desc = "fail on any/all arp targets timeout",
+               .values = bond_arp_all_targets_tbl,
+               .set = bond_option_arp_all_targets_set
+       },
        { }
 };
 
@@ -767,19 +780,12 @@ int bond_option_arp_validate_set(struct bonding *bond,
        return 0;
 }
 
-int bond_option_arp_all_targets_set(struct bonding *bond, int arp_all_targets)
+int bond_option_arp_all_targets_set(struct bonding *bond,
+                                   struct bond_opt_value *newval)
 {
-       if (bond_parm_tbl_lookup(arp_all_targets, arp_all_targets_tbl) < 0) {
-               pr_err("%s: Ignoring invalid arp_all_targets value %d.\n",
-                      bond->dev->name, arp_all_targets);
-               return -EINVAL;
-       }
-
-       pr_info("%s: setting arp_all_targets to %s (%d).\n",
-               bond->dev->name, arp_all_targets_tbl[arp_all_targets].modename,
-               arp_all_targets);
-
-       bond->params.arp_all_targets = arp_all_targets;
+       pr_info("%s: setting arp_all_targets to %s (%llu).\n",
+               bond->dev->name, newval->string, newval->value);
+       bond->params.arp_all_targets = newval->value;
 
        return 0;
 }

diff --git a/drivers/net/bonding/bond_options.h b/drivers/net/bonding/bond_options.h
index 15c6c0185b2e0dbb9dd96041c0705d6b7941e6ea..88f8c178b2333e20f23a94a85d5c1301182ea94d 100644 (file)
--- a/drivers/net/bonding/bond_options.h
+++ b/drivers/net/bonding/bond_options.h
@@ -42,6 +42,7 @@ enum {
        BOND_OPT_PACKETS_PER_SLAVE,
        BOND_OPT_XMIT_HASH,
        BOND_OPT_ARP_VALIDATE,
+       BOND_OPT_ARP_ALL_TARGETS,
        BOND_OPT_LAST
 };
 
@@ -108,4 +109,6 @@ int bond_option_xmit_hash_policy_set(struct bonding *bond,
                                     struct bond_opt_value *newval);
 int bond_option_arp_validate_set(struct bonding *bond,
                                 struct bond_opt_value *newval);
+int bond_option_arp_all_targets_set(struct bonding *bond,
+                                   struct bond_opt_value *newval);
 #endif /* _BOND_OPTIONS_H */

diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index e1a4b633013fbdf14fd797c87949967e379a1ba2..83463fc7622b8ef5647739b61cb343c76b5a256c 100644 (file)
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -357,10 +357,12 @@ static ssize_t bonding_show_arp_all_targets(struct device *d,
                                         char *buf)
 {
        struct bonding *bond = to_bond(d);
-       int value = bond->params.arp_all_targets;
+       struct bond_opt_value *val;
 
-       return sprintf(buf, "%s %d\n", arp_all_targets_tbl[value].modename,
-                      value);
+       val = bond_opt_get_val(BOND_OPT_ARP_ALL_TARGETS,
+                              bond->params.arp_all_targets);
+       return sprintf(buf, "%s %d\n",
+                      val->string, bond->params.arp_all_targets);
 }
 
 static ssize_t bonding_store_arp_all_targets(struct device *d,
@@ -368,24 +370,12 @@ static ssize_t bonding_store_arp_all_targets(struct device *d,
                                          const char *buf, size_t count)
 {
        struct bonding *bond = to_bond(d);
-       int new_value, ret;
-
-       new_value = bond_parse_parm(buf, arp_all_targets_tbl);
-       if (new_value < 0) {
-               pr_err("%s: Ignoring invalid arp_all_targets value %s\n",
-                      bond->dev->name, buf);
-               return -EINVAL;
-       }
-
-       if (!rtnl_trylock())
-               return restart_syscall();
+       int ret;
 
-       ret = bond_option_arp_all_targets_set(bond, new_value);
+       ret = bond_opt_tryset_rtnl(bond, BOND_OPT_ARP_ALL_TARGETS, (char *)buf);
        if (!ret)
                ret = count;
 
-       rtnl_unlock();
-
        return ret;
 }
 

diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 9af61716d78af413a62bc7fe222522e536d54241..18b948ad28d3f9ab1e1bf70501f2897891a686af 100644 (file)
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -462,7 +462,6 @@ int bond_option_arp_ip_targets_set(struct bonding *bond, __be32 *targets,
                                   int count);
 int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target);
 int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target);
-int bond_option_arp_all_targets_set(struct bonding *bond, int arp_all_targets);
 int bond_option_primary_set(struct bonding *bond, const char *primary);
 int bond_option_primary_reselect_set(struct bonding *bond,
                                     int primary_reselect);