perf top: Add missing newline if the 'uid' is invalid
authorIngo Molnar <mingo@kernel.org>
Tue, 12 Nov 2013 23:26:09 +0000 (00:26 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 14 Nov 2013 18:59:50 +0000 (15:59 -0300)
Add missing newline if the 'uid' is invalid:

  hubble:~> perf top --stdio -u help
  Error:
  Invalid User: helphubble:~>

Fixed by this patch:

  comet:~/tip/tools/perf> perf top --stdio -u help
  Error:
  Invalid User: help
  comet:~/tip/tools/perf>

Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/20131112232609.GA31474@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c

index b8f8e29db332df707887284d539b6ad6f3d5840f..71e6402729a8616bf9b9fe8e2141ea08ac0bbca2 100644 (file)
@@ -1172,7 +1172,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
        status = target__validate(target);
        if (status) {
                target__strerror(target, status, errbuf, BUFSIZ);
-               ui__warning("%s", errbuf);
+               ui__warning("%s\n", errbuf);
        }
 
        status = target__parse_uid(target);
@@ -1180,7 +1180,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
                int saved_errno = errno;
 
                target__strerror(target, status, errbuf, BUFSIZ);
-               ui__error("%s", errbuf);
+               ui__error("%s\n", errbuf);
 
                status = -saved_errno;
                goto out_delete_evlist;