net: atl1: slight optimization of addr compare
authordingtianhong <dingtianhong@huawei.com>
Thu, 26 Dec 2013 11:40:27 +0000 (19:40 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Dec 2013 18:31:33 +0000 (13:31 -0500)
Use the recently added and possibly more efficient
ether_addr_equal_unaligned to instead of memcmp.

Cc: Jay Cliburn <jcliburn@gmail.com>
Cc: Chris Snook <chris.snook@gmail.com>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/atlx/atl1.c

index 538211d6f7d9ad5fc806008a58d984750c91edcd..55d86ecdacfe3b553ea92b0bc691f884717c5160 100644 (file)
@@ -3122,7 +3122,8 @@ static void atl1_remove(struct pci_dev *pdev)
         * from the BIOS during POST.  If we've been messing with the MAC
         * address, we need to save the permanent one.
         */
-       if (memcmp(adapter->hw.mac_addr, adapter->hw.perm_mac_addr, ETH_ALEN)) {
+       if (!ether_addr_equal_unaligned(adapter->hw.mac_addr,
+                                       adapter->hw.perm_mac_addr)) {
                memcpy(adapter->hw.mac_addr, adapter->hw.perm_mac_addr,
                        ETH_ALEN);
                atl1_set_mac_addr(&adapter->hw);