NTB: Correctly handle receive buffers of the minimal size
authorJon Mason <jon.mason@intel.com>
Fri, 1 Feb 2013 22:45:16 +0000 (15:45 -0700)
committerJon Mason <jon.mason@intel.com>
Wed, 15 May 2013 17:57:59 +0000 (10:57 -0700)
The ring logic of the NTB receive buffer/transmit memory window requires
there to be at least 2 payload sized allotments.  For the minimal size
case, split the buffer into two and set the transport_mtu to the
appropriate size.

Signed-off-by: Jon Mason <jon.mason@intel.com>
drivers/ntb/ntb_transport.c

index 73a000ed7a9fe201ae35f35fd6bd97c12409e2d4..cd9745b062e46e5722dafddf8f67decb6d9979a7 100644 (file)
@@ -490,11 +490,12 @@ static void ntb_transport_setup_qp_mw(struct ntb_transport *nt,
        rx_size -= sizeof(struct ntb_rx_info);
 
        qp->rx_buff = qp->remote_rx_info + 1;
-       qp->rx_max_frame = min(transport_mtu, rx_size);
+       /* Due to housekeeping, there must be atleast 2 buffs */
+       qp->rx_max_frame = min(transport_mtu, rx_size / 2);
        qp->rx_max_entry = rx_size / qp->rx_max_frame;
        qp->rx_index = 0;
 
-       qp->remote_rx_info->entry = qp->rx_max_entry;
+       qp->remote_rx_info->entry = qp->rx_max_entry - 1;
 
        /* setup the hdr offsets with 0's */
        for (i = 0; i < qp->rx_max_entry; i++) {
@@ -818,7 +819,8 @@ static void ntb_transport_init_queue(struct ntb_transport *nt,
        tx_size -= sizeof(struct ntb_rx_info);
 
        qp->tx_mw = qp->rx_info + 1;
-       qp->tx_max_frame = min(transport_mtu, tx_size);
+       /* Due to housekeeping, there must be atleast 2 buffs */
+       qp->tx_max_frame = min(transport_mtu, tx_size / 2);
        qp->tx_max_entry = tx_size / qp->tx_max_frame;
 
        if (nt->debugfs_dir) {