[PATCH] bug fix in kernel/kmod.c
authorKenneth Lee <kenlee@dg.gov.cn>
Sat, 16 Sep 2006 19:15:55 +0000 (12:15 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 16 Sep 2006 19:54:32 +0000 (12:54 -0700)
commite4b69aa2a1bcee21f8d5e089b8682dd8aaace5eb
treeccc3ff548d892965999d2ec2d64617e6daff41ac
parent1ab7a1f3b496aae5b1e062a6f50d62830c248190
[PATCH] bug fix in kernel/kmod.c

I think there is a bug in kmod.c: In __call_usermodehelper(), when
kernel_thread(wait_for_helper, ...) return success, since wait_for_helper()
might call complete() at any time, the sub_info should not be used any
more.

Normally wait_for_helper() take a long time to finish, you may not get
problem for most of the case.  But if you remove /sbin/modprobe, it may
become easier for you to get a oop in khelper.

Cc: Matt Helsley <matthltc@us.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/kmod.c