ethtool: Fix potential user buffer overflow for ETHTOOL_{G, S}RXFH
authorBen Hutchings <bhutchings@solarflare.com>
Mon, 28 Jun 2010 08:45:58 +0000 (08:45 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Jun 2010 08:00:29 +0000 (01:00 -0700)
commitbf988435bd5b53529f4408a8efb1f433f6ddfda9
tree7805f577d019f587146b4fd1cf642faacfec2f14
parentdb048b69037e7fa6a7d9e95a1271a50dc08ae233
ethtool: Fix potential user buffer overflow for ETHTOOL_{G, S}RXFH

struct ethtool_rxnfc was originally defined in 2.6.27 for the
ETHTOOL_{G,S}RXFH command with only the cmd, flow_type and data
fields.  It was then extended in 2.6.30 to support various additional
commands.  These commands should have been defined to use a new
structure, but it is too late to change that now.

Since user-space may still be using the old structure definition
for the ETHTOOL_{G,S}RXFH commands, and since they do not need the
additional fields, only copy the originally defined fields to and
from user-space.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Cc: stable@kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/ethtool.h
net/core/ethtool.c