mfd: rtsx_usb: Fix runtime PM deadlock
authorRoger Tseng <rogerable@realtek.com>
Thu, 15 Jan 2015 07:14:44 +0000 (15:14 +0800)
committerLee Jones <lee.jones@linaro.org>
Tue, 20 Jan 2015 12:52:55 +0000 (12:52 +0000)
commitb166010f6afbadb896efa37ff85eb681a8f89392
treed5c1707fd9e1e9e8f0c328701a55d63784ab3324
parentf29ae369a412942e81035984fa3d7a22ddf91fcb
mfd: rtsx_usb: Fix runtime PM deadlock

sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c
acquires dev_mutex and then calls pm_runtime_get_sync() to make sure the
device is awake while initializing a newly inserted card. Once it is
called during suspending state and explicitly before rtsx_usb_suspend()
acquires the same dev_mutex, both routine deadlock and further hang the
driver because pm_runtime_get_sync() waits the pending PM operations.

Fix this by using an empty suspend method. mmc_core always turns the
LED off after a request is done and thus it is ok to remove the only
rtsx_usb_turn_off_led() here.

Cc: <stable@vger.kernel.org> # v3.16+
Fixes: 730876be2566 ("mfd: Add realtek USB card reader driver")
Signed-off-by: Roger Tseng <rogerable@realtek.com>
[Lee: Removed newly unused variable]
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/rtsx_usb.c