blk-mq: Fix use after of free q->mq_map
authorAkinobu Mita <akinobu.mita@gmail.com>
Sat, 26 Sep 2015 17:09:21 +0000 (02:09 +0900)
committerJens Axboe <axboe@fb.com>
Tue, 29 Sep 2015 17:32:46 +0000 (11:32 -0600)
commita723bab3d7529133f71fc8a5e96f86e3639a0d13
tree658d5b5c71b7851f34ed07ce8c0022915acd33e4
parent4593fdbe7a2f44d5e64c627c715dd0bcec9bdf14
blk-mq: Fix use after of free q->mq_map

CPU hotplug handling for blk-mq (blk_mq_queue_reinit) updates
q->mq_map by blk_mq_update_queue_map() for all request queues in
all_q_list.  On the other hand, q->mq_map is released before deleting
the queue from all_q_list.

So if CPU hotplug event occurs in the window, invalid memory access
can happen.  Fix it by releasing q->mq_map in blk_mq_release() to make
it happen latter than removal from all_q_list.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Suggested-by: Ming Lei <tom.leiming@gmail.com>
Reviewed-by: Ming Lei <tom.leiming@gmail.com>
Cc: Ming Lei <tom.leiming@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-mq.c