lockdep/proc: Fix lock-time avg computation
authorPeter Zijlstra <peterz@infradead.org>
Wed, 6 Nov 2013 16:42:30 +0000 (17:42 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 11 Nov 2013 11:41:34 +0000 (12:41 +0100)
commit838cc7b488f89ee642fd8336e8e1b620c8c3ece2
treefddaa3f2d4a5125969707106e87112a3c4c2fd53
parent67a6de49bf545c34eb8dee99abbb92d9ea268200
lockdep/proc: Fix lock-time avg computation

>    kernel/locking/lockdep_proc.c: In function 'seq_lock_time':
> >> kernel/locking/lockdep_proc.c:424:23: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>
>    418 static void seq_lock_time(struct seq_file *m, struct lock_time *lt)
>    419 {
>    420 seq_printf(m, "%14lu", lt->nr);
>    421 seq_time(m, lt->min);
>    422 seq_time(m, lt->max);
>    423 seq_time(m, lt->total);
>  > 424 seq_time(m, lt->nr ? do_div(lt->total, lt->nr) : 0);
>    425 }

My compiler refuses to actually say that; but it looks wrong in that
do_div() returns the remainder, not the divisor.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Davidlohr Bueso <davidlohr@hp.com>
Link: http://lkml.kernel.org/r/20131106164230.GE16117@laptop.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/lockdep_proc.c