ext4: check s_chksum_driver when looking for bg csum presence
authorDarrick J. Wong <darrick.wong@oracle.com>
Tue, 14 Oct 2014 06:35:49 +0000 (02:35 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 14 Oct 2014 06:35:49 +0000 (02:35 -0400)
commit813d32f91333e4c33d5a19b67167c4bae42dae75
tree09e1183d369c6b42a6fc3edcb73017ff54aa8a36
parentaef4885ae14f1df75b58395c5314d71f613d26d9
ext4: check s_chksum_driver when looking for bg csum presence

Convert the ext4_has_group_desc_csum predicate to look for a checksum
driver instead of the metadata_csum flag and change the bg checksum
calculation function to look for GDT_CSUM before taking the crc16
path.

Without this patch, if we mount with ^uninit_bg,^metadata_csum and
later metadata_csum gets turned on by accident, the block group
checksum functions will incorrectly assume that checksumming is
enabled (metadata_csum) but that crc16 should be used
(!s_chksum_driver).  This is totally wrong, so fix the predicate
and the checksum formula selection.

(Granted, if the metadata_csum feature bit gets enabled on a live FS
then something underhanded is going on, but we could at least avoid
writing garbage into the on-disk fields.)

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: stable@vger.kernel.org
fs/ext4/ext4.h
fs/ext4/super.c