ALSA: oxfw: some signedness bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 12 Dec 2014 19:27:03 +0000 (22:27 +0300)
committerTakashi Iwai <tiwai@suse.de>
Mon, 15 Dec 2014 09:03:21 +0000 (10:03 +0100)
commit5580ba7bf61a6047a8b95459a9ed893f01947737
tree2e43097b2912444d3a42803058a4eb93c7f69823
parent0d3aba30b755fe9ccaf390f0e71f6fb9fd55bd87
ALSA: oxfw: some signedness bugs

This code tends to use unsigned variables by default and it causes
signedness bugs when we use negative variables for error handling.
The "i" and "j" variables are used to iterated over small positive
values and so they should be type "int".  The "len" variable doesn't
*need* to be signed but it should be signed to make the code easier to
read and audit.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/oxfw/oxfw-pcm.c
sound/firewire/oxfw/oxfw-proc.c
sound/firewire/oxfw/oxfw-stream.c