xen-netback: stop the guest rx thread after a fatal error
authorDavid Vrabel <david.vrabel@citrix.com>
Mon, 2 Feb 2015 16:57:51 +0000 (16:57 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Feb 2015 03:39:04 +0000 (19:39 -0800)
commit42b5212fee4f57907e9415b18fe19c13e65574bc
tree3fb44adcfd6de16f9e3ceddcf46d7a2c9c54532c
parent5a2e87b16875f9b83b7e9494cf1fce8e17dc764a
xen-netback: stop the guest rx thread after a fatal error

After commit e9d8b2c2968499c1f96563e6522c56958d5a1d0d (xen-netback:
disable rogue vif in kthread context), a fatal (protocol) error would
leave the guest Rx thread spinning, wasting CPU time.  Commit
ecf08d2dbb96d5a4b4bcc53a39e8d29cc8fef02e (xen-netback: reintroduce
guest Rx stall detection) made this even worse by removing a
cond_resched() from this path.

Since a fatal error is non-recoverable, just allow the guest Rx thread
to exit.  This requires taking additional refs to the task so the
thread exiting early is handled safely.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reported-by: Julien Grall <julien.grall@linaro.org>
Tested-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/interface.c
drivers/net/xen-netback/netback.c