iio:adc:vf610 ensure correct handing of interruption of wait for completion iio-for-3.15c
authorJonathan Cameron <jic23@kernel.org>
Fri, 3 Jan 2014 22:02:00 +0000 (22:02 +0000)
committerJonathan Cameron <jic23@kernel.org>
Sun, 2 Mar 2014 21:45:28 +0000 (21:45 +0000)
Issue highlighted by smatch warning:

CHECK   drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never less than zero.

As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if
interrupted, ret must be signed.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Fugang Duan <B38611@freescale.com>
drivers/iio/adc/vf610_adc.c

index 37f542e8233cea8cb01106875157b2df3733a5ea..44799eb5930e2e03e71f9a4381165447b62b839a 100644 (file)
@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev,
 {
        struct vf610_adc *info = iio_priv(indio_dev);
        unsigned int hc_cfg;
-       unsigned long ret;
+       long ret;
 
        switch (mask) {
        case IIO_CHAN_INFO_RAW: