SUNRPC: Fix the return value of rpc_run_bc_task()
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 19 Mar 2010 20:17:45 +0000 (16:17 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 22 Mar 2010 09:34:12 +0000 (05:34 -0400)
Currently rpc_run_bc_task() will return NULL if the task allocation failed.
However the only caller is bc_send, which assumes that the return value
will be an ERR_PTR.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/clnt.c

index 154034b675bd90de493d1438ff46a2b230178742..19c9983d53607483cce29654b8e589dca6da539d 100644 (file)
@@ -659,6 +659,7 @@ struct rpc_task *rpc_run_bc_task(struct rpc_rqst *req,
        task = rpc_new_task(&task_setup_data);
        if (!task) {
                xprt_free_bc_request(req);
+               task = ERR_PTR(-ENOMEM);
                goto out;
        }
        task->tk_rqstp = req;