xdp: sample: Missing curly braces in read_route()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 Nov 2017 06:12:03 +0000 (09:12 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Nov 2017 13:00:13 +0000 (22:00 +0900)
The assert statement is supposed to be part of the else branch but the
curly braces were accidentally left off.

Fixes: 3e29cd0e6563 ("xdp: Sample xdp program implementing ip forward")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
samples/bpf/xdp_router_ipv4_user.c

index 2c1fe3f4b1a482c05645dfa84e469bea7abb4df6..916462112d55e0a3740cad8324c2c657871f719d 100644 (file)
@@ -206,12 +206,13 @@ static void read_route(struct nlmsghdr *nh, int nll)
                        direct_entry.arp.mac = 0;
                        direct_entry.arp.dst = 0;
                        if (route.dst_len == 32) {
-                               if (nh->nlmsg_type == RTM_DELROUTE)
+                               if (nh->nlmsg_type == RTM_DELROUTE) {
                                        assert(bpf_map_delete_elem(map_fd[3], &route.dst) == 0);
-                               else
+                               } else {
                                        if (bpf_map_lookup_elem(map_fd[2], &route.dst, &direct_entry.arp.mac) == 0)
                                                direct_entry.arp.dst = route.dst;
                                        assert(bpf_map_update_elem(map_fd[3], &route.dst, &direct_entry, 0) == 0);
+                               }
                        }
                        for (i = 0; i < 4; i++)
                                prefix_key->data[i] = (route.dst >> i * 8) & 0xff;