fbdev: fix error return code in metronomefb_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Sat, 12 Oct 2013 06:25:23 +0000 (14:25 +0800)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 29 Oct 2013 10:20:11 +0000 (12:20 +0200)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/metronomefb.c

index 2d7dd8ea43f6b4a04a2515c606b9b789fbb8e491..195cc2db4c2c0ecc4c4755a793118f87fce8e96f 100644 (file)
@@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev)
                goto err_csum_table;
        }
 
-       if (board->setup_irq(info))
+       retval = board->setup_irq(info);
+       if (retval)
                goto err_csum_table;
 
        retval = metronome_init_regs(par);