usb: dwc3: pci: Properly cleanup resource
authorThinh Nguyen <Thinh.Nguyen@synopsys.com>
Mon, 19 Mar 2018 20:07:35 +0000 (13:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Apr 2018 07:29:25 +0000 (09:29 +0200)
commit cabdf83dadfb3d83eec31e0f0638a92dbd716435 upstream.

Platform device is allocated before adding resources. Make sure to
properly cleanup on error case.

Cc: <stable@vger.kernel.org>
Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()")
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-pci.c

index a36cf66302fbe56e06f6ed20451b8c008479b0d2..489e1c0dba29383c51469c8af39a60b4f5bc26b8 100644 (file)
@@ -143,7 +143,7 @@ static int dwc3_pci_probe(struct pci_dev *pci,
        ret = platform_device_add_resources(dwc3, res, ARRAY_SIZE(res));
        if (ret) {
                dev_err(dev, "couldn't add resources to dwc3 device\n");
-               return ret;
+               goto err3;
        }
 
        pci_set_drvdata(pci, glue);