regulator: palmas: rename probe/remove callback functions
authorLaxman Dewangan <ldewangan@nvidia.com>
Mon, 18 Mar 2013 09:29:49 +0000 (14:59 +0530)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 20 Mar 2013 12:38:09 +0000 (13:38 +0100)
When palmas regulator probe creates stack dump during initialization
due to some crash, it prints the call trace as follows:
[3.166321] [<c028fa20>] (_regmap_read+0x5c/0xa8) from [<c028fab0>] (regmap_read+0x44/0x5c)
[3.174669] [<c028fab0>] (regmap_read+0x44/0x5c) from [<c023062c>] (palmas_probe+0x240/0x7d0)
[3.183193] [<c023062c>] (palmas_probe+0x240/0x7d0) from [<c0284064>] (platform_drv_probe+0x14/0x18)
[3.192322] [<c0284064>] (platform_drv_probe+0x14/0x18) from [<c0282ee4>] (driver_probe_device+0x104/0x214)
[3.202055] [<c0282ee4>] (driver_probe_device+0x104/0x214) from [<c028167c>] (bus_for_each_drv+0x5c/0x88)

The palmas_probe is current name but it helps on debugging if the
function name is more appropriate to the sub-module name.

Renaming the palmas_probe() to palmas_regulator_probe() and
palmas_remove() to palams_regulator_remove().

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/regulator/palmas-regulator.c

index 122fea432d38b405aa4182e73b8c36000b71adb2..aec2d76096dd1ff84f32aad3eab4d518bd26fa03 100644 (file)
@@ -581,7 +581,7 @@ static void palmas_dt_to_pdata(struct device *dev,
 }
 
 
-static int palmas_probe(struct platform_device *pdev)
+static int palmas_regulators_probe(struct platform_device *pdev)
 {
        struct palmas *palmas = dev_get_drvdata(pdev->dev.parent);
        struct palmas_pmic_platform_data *pdata = pdev->dev.platform_data;
@@ -790,7 +790,7 @@ err_unregister_regulator:
        return ret;
 }
 
-static int palmas_remove(struct platform_device *pdev)
+static int palmas_regulators_remove(struct platform_device *pdev)
 {
        struct palmas_pmic *pmic = platform_get_drvdata(pdev);
        int id;
@@ -818,8 +818,8 @@ static struct platform_driver palmas_driver = {
                .of_match_table = of_palmas_match_tbl,
                .owner = THIS_MODULE,
        },
-       .probe = palmas_probe,
-       .remove = palmas_remove,
+       .probe = palmas_regulators_probe,
+       .remove = palmas_regulators_remove,
 };
 
 static int __init palmas_init(void)