drm/exynos/fbdev: don't set mode_config.fb_base
authorDaniel Kurtz <djkurtz@chromium.org>
Fri, 4 Apr 2014 09:22:02 +0000 (17:22 +0800)
committerInki Dae <daeinki@gmail.com>
Sun, 1 Jun 2014 17:07:02 +0000 (02:07 +0900)
AFAICT, the fb_base of a drm_device's mode_config is never used.  It isn't
accessed by core drm, it isn't used by fbmem, and it isn't exposed to user
space.

Furthermore, it is probably supposed to be a physical address, not the
dma address mapped to the display controller, so this is just wrong.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_fbdev.c

index c5c00f2093703f7d00c3b580a917dd0787c62faa..578ebbbcb81bc9cf670619a8a488df0919cf20dd 100644 (file)
@@ -121,7 +121,6 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
        offset = fbi->var.xoffset * (fb->bits_per_pixel >> 3);
        offset += fbi->var.yoffset * fb->pitches[0];
 
-       dev->mode_config.fb_base = (resource_size_t)buffer->dma_addr;
        fbi->screen_base = buffer->kvaddr + offset;
        fbi->screen_size = size;