dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly
authorXin Long <lucien.xin@gmail.com>
Wed, 26 Jul 2017 06:19:46 +0000 (14:19 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Jul 2017 07:01:05 +0000 (00:01 -0700)
The patch "dccp: fix a memleak that dccp_ipv6 doesn't put reqsk
properly" fixed reqsk refcnt leak for dccp_ipv6. The same issue
exists on dccp_ipv4.

This patch is to fix it for dccp_ipv4.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ipv4.c

index f85d901f4e3fc02741ad20f3ff3066108af1e7e8..1b202f16531fce72860a78d89ca1af716f883d99 100644 (file)
@@ -631,6 +631,7 @@ int dccp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
                goto drop_and_free;
 
        inet_csk_reqsk_queue_hash_add(sk, req, DCCP_TIMEOUT_INIT);
+       reqsk_put(req);
        return 0;
 
 drop_and_free: