[media] drivers/media/platform/mx2_emmaprp.c: adjust inconsistent IS_ERR and PTR_ERR
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 25 Aug 2012 18:57:05 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 15 Sep 2012 16:09:21 +0000 (13:09 -0300)
Change the call to IS_ERR to test the value that was just initialized and
is returned using PTR_ERR.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1;
@@

(
if (IS_ERR(e)) { ... PTR_ERR(e) ... }
|
if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... }
|
*if (IS_ERR(e))
 { ...
*  PTR_ERR(e1)
   ... }
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/mx2_emmaprp.c

index 59aaca4de1831304a6adfcacf7de6fb94a457f57..2236315778c3828c5387c0632d743c9c0773ae54 100644 (file)
@@ -906,9 +906,8 @@ static int emmaprp_probe(struct platform_device *pdev)
        }
 
        pcdev->clk_emma_ahb = devm_clk_get(&pdev->dev, "ahb");
-       if (IS_ERR(pcdev->clk_emma_ipg)) {
+       if (IS_ERR(pcdev->clk_emma_ahb))
                return PTR_ERR(pcdev->clk_emma_ahb);
-       }
 
        irq_emma = platform_get_irq(pdev, 0);
        res_emma = platform_get_resource(pdev, IORESOURCE_MEM, 0);