bridge: avoid OOPS if root port not found

Bridge can crash while trying to send topology change packet.
This happens if root port can't be found. This was reported by user
but currently unable to reproduce it easily. The STP conditions that cause
this are not known yet, but the problem doesn't have to be fatal.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index b01849a743101a16e99eebb3a0ef653242c98330..1c0a50f132293e0fb15e506620459047a8e1075b 100644 (file)
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -225,7 +225,14 @@ static void br_record_config_timeout_values(struct net_bridge *br,
 /* called under bridge lock */
 void br_transmit_tcn(struct net_bridge *br)
 {
-       br_send_tcn_bpdu(br_get_port(br, br->root_port));
+       struct net_bridge_port *p;
+
+       p = br_get_port(br, br->root_port);
+       if (p)
+               br_send_tcn_bpdu(p);
+       else
+               br_notice(br, "root port %u not found for topology notice\n",
+                         br->root_port);
 }
 
 /* called under bridge lock */