MIPS: Lantiq: Use strlcpy() instead of strncpy().
authorChen Gang <gang.chen@asianux.com>
Sun, 26 May 2013 06:51:49 +0000 (06:51 +0000)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 10 Jun 2013 16:01:25 +0000 (18:01 +0200)
'compatible' is used by strlen() in __of_device_is_compatible().

Ensure strings are always '\0' terminated.

'of_ids is not a structure in "include/uapi/*", so no need to initialize
it completly; using strlcpy() instead of strncpy() will do.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org
Cc: Linux-Arch <linux-arch@vger.kernel.org>
Patchwork: https://patchwork.linux-mips.org/patch/5329/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/lantiq/prom.c

index 9f9e875967aa21244e2d8578a8830096fab27c89..49c460370285900cf7abe9b788b5e346049b9753 100644 (file)
@@ -112,7 +112,7 @@ int __init plat_of_setup(void)
        if (!of_have_populated_dt())
                panic("device tree not present");
 
-       strncpy(of_ids[0].compatible, soc_info.compatible,
+       strlcpy(of_ids[0].compatible, soc_info.compatible,
                sizeof(of_ids[0].compatible));
        strncpy(of_ids[1].compatible, "simple-bus",
                sizeof(of_ids[1].compatible));