staging: dgnc: remove parenthesis
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Sun, 4 Oct 2015 14:20:15 +0000 (19:50 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Oct 2015 04:08:51 +0000 (21:08 -0700)
checkpatch was warning us about extra unneeded parenthesis.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgnc/dgnc_neo.c
drivers/staging/dgnc/dgnc_sysfs.c
drivers/staging/dgnc/dgnc_tty.c

index 99287bb90b59ed7905e113f089f61e938ac9952d..8106f5234bf519e6d79efdd903b8d0dff02a8356 100644 (file)
@@ -1792,6 +1792,6 @@ static void neo_vpd(struct dgnc_board *brd)
                /* Search for the serial number */
                for (i = 0; i < NEO_VPD_IMAGEBYTES - 3; i++)
                        if (brd->vpd[i] == 'S' && brd->vpd[i + 1] == 'N')
-                               strncpy(brd->serial_num, &(brd->vpd[i + 3]), 9);
+                               strncpy(brd->serial_num, &brd->vpd[i + 3], 9);
        }
 }
index dffb4af12023910ab1577233d4a55c5396950073..74a072599126f535471c932d2af00a67cfd57f72 100644 (file)
@@ -343,18 +343,18 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
        int rc = 0;
 
        dev_set_drvdata(&bd->pdev->dev, bd);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_state);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_baud);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_msignals);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_iflag);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_cflag);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_oflag);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_lflag);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_digi_flag);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_rxcount);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_txcount);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd);
-       rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_state);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_baud);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_msignals);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_iflag);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_cflag);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_oflag);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_lflag);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_digi_flag);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_rxcount);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_ports_txcount);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_vpd);
+       rc |= device_create_file(&bd->pdev->dev, &dev_attr_serial_number);
        if (rc)
                dev_err(&bd->pdev->dev, "dgnc: sysfs device_create_file failed!\n");
 }
@@ -362,18 +362,18 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
 /* removes all the sys files created for that port */
 void dgnc_remove_ports_sysfiles(struct dgnc_board *bd)
 {
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_state);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_baud);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_msignals);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_iflag);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_cflag);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_oflag);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_lflag);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_digi_flag);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_rxcount);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_ports_txcount);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_vpd);
-       device_remove_file(&(bd->pdev->dev), &dev_attr_serial_number);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_state);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_baud);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_msignals);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_iflag);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_cflag);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_oflag);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_lflag);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_digi_flag);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_rxcount);
+       device_remove_file(&bd->pdev->dev, &dev_attr_ports_txcount);
+       device_remove_file(&bd->pdev->dev, &dev_attr_vpd);
+       device_remove_file(&bd->pdev->dev, &dev_attr_serial_number);
 }
 
 static ssize_t dgnc_tty_state_show(struct device *d,
index 18f0dae6e038a3b76afb6fc9c28e8aa48c6dac55..8489e5a1dae813c9f1676ac3f3f6c5b754e1cb29 100644 (file)
@@ -365,12 +365,12 @@ int dgnc_tty_init(struct dgnc_board *brd)
                        struct device *classp;
 
                        classp = tty_register_device(&brd->SerialDriver, i,
-                                                    &(ch->ch_bd->pdev->dev));
+                                                    &ch->ch_bd->pdev->dev);
                        ch->ch_tun.un_sysfs = classp;
                        dgnc_create_tty_sysfs(&ch->ch_tun, classp);
 
                        classp = tty_register_device(&brd->PrintDriver, i,
-                                                    &(ch->ch_bd->pdev->dev));
+                                                    &ch->ch_bd->pdev->dev);
                        ch->ch_pun.un_sysfs = classp;
                        dgnc_create_tty_sysfs(&ch->ch_pun, classp);
                }
@@ -710,7 +710,7 @@ void dgnc_carrier(struct channel_t *ch)
                 * for carrier in the open routine.
                 */
 
-               if (waitqueue_active(&(ch->ch_flags_wait)))
+               if (waitqueue_active(&ch->ch_flags_wait))
                        wake_up_interruptible(&ch->ch_flags_wait);
        }
 
@@ -723,7 +723,7 @@ void dgnc_carrier(struct channel_t *ch)
                 * for carrier in the open routine.
                 */
 
-               if (waitqueue_active(&(ch->ch_flags_wait)))
+               if (waitqueue_active(&ch->ch_flags_wait))
                        wake_up_interruptible(&ch->ch_flags_wait);
        }
 
@@ -750,7 +750,7 @@ void dgnc_carrier(struct channel_t *ch)
                 *
                 *   Enable all select calls.
                 */
-               if (waitqueue_active(&(ch->ch_flags_wait)))
+               if (waitqueue_active(&ch->ch_flags_wait))
                        wake_up_interruptible(&ch->ch_flags_wait);
 
                if (ch->ch_tun.un_open_count > 0)
@@ -936,7 +936,7 @@ void dgnc_wakeup_writes(struct channel_t *ch)
                if ((ch->ch_tun.un_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
                    ch->ch_tun.un_tty->ldisc->ops->write_wakeup) {
                        spin_unlock_irqrestore(&ch->ch_lock, flags);
-                       (ch->ch_tun.un_tty->ldisc->ops->write_wakeup)(ch->ch_tun.un_tty);
+                       ch->ch_tun.un_tty->ldisc->ops->write_wakeup(ch->ch_tun.un_tty);
                        spin_lock_irqsave(&ch->ch_lock, flags);
                }
 
@@ -978,7 +978,7 @@ void dgnc_wakeup_writes(struct channel_t *ch)
                if ((ch->ch_pun.un_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
                    ch->ch_pun.un_tty->ldisc->ops->write_wakeup) {
                        spin_unlock_irqrestore(&ch->ch_lock, flags);
-                       (ch->ch_pun.un_tty->ldisc->ops->write_wakeup)(ch->ch_pun.un_tty);
+                       ch->ch_pun.un_tty->ldisc->ops->write_wakeup(ch->ch_pun.un_tty);
                        spin_lock_irqsave(&ch->ch_lock, flags);
                }