netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 2 Feb 2015 09:01:45 +0000 (10:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Feb 2015 00:22:12 +0000 (16:22 -0800)
The cipso_v4_doi_putdef() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlabel/netlabel_mgmt.c

index 8b3b789c43c2def93c6f7192a51f75e2074dc143..f5807f57aebc70ce8b6ae4da382e130b4b23bfaa 100644 (file)
@@ -242,8 +242,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
        return 0;
 
 add_failure:
-       if (cipsov4)
-               cipso_v4_doi_putdef(cipsov4);
+       cipso_v4_doi_putdef(cipsov4);
        if (entry)
                kfree(entry->domain);
        kfree(addrmap);