[PATCH] Fix wrong /proc/iomem on SGI Altix
authorBernhard Walle <bwalle@suse.de>
Sun, 18 Mar 2007 09:26:08 +0000 (01:26 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Sun, 18 Mar 2007 18:35:07 +0000 (11:35 -0700)
In sn_io_slot_fixup(), the parent is re-set from the bus to
io(port|mem)_resource because the address is changed in a way that it's not
child of the bus any more.

However, only the root is set but not the parent/child/sibling relationship
in the resource tree which causes 'cat /proc/iomem' to stop after this
memory area.  Depding on the poition in the tree the iomem may be nearly
completely empty.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
Cc: John Keller <jpk@sgi.com>
Cc: Jay Lan <jlan@engr.sgi.com>
Acked-by: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/ia64/sn/kernel/io_init.c

index 600be3ebae05b660247050b2393057f22b49eda3..6b10e5d284883380a284a1d2616e1aa2ec834fd2 100644 (file)
@@ -247,10 +247,18 @@ sn_io_slot_fixup(struct pci_dev *dev)
                addr = ((addr << 4) >> 4) | __IA64_UNCACHED_OFFSET;
                dev->resource[idx].start = addr;
                dev->resource[idx].end = addr + size;
+
+               /*
+                * if it's already in the device structure, remove it before
+                * inserting
+                */
+               if (dev->resource[idx].parent && dev->resource[idx].parent->child)
+                       release_resource(&dev->resource[idx]);
+
                if (dev->resource[idx].flags & IORESOURCE_IO)
-                       dev->resource[idx].parent = &ioport_resource;
+                       insert_resource(&ioport_resource, &dev->resource[idx]);
                else
-                       dev->resource[idx].parent = &iomem_resource;
+                       insert_resource(&iomem_resource, &dev->resource[idx]);
                /* If ROM, mark as shadowed in PROM */
                if (idx == PCI_ROM_RESOURCE)
                        dev->resource[idx].flags |= IORESOURCE_ROM_BIOS_COPY;