libceph: drop authorizer check from cephx msg signing routines
authorIlya Dryomov <idryomov@gmail.com>
Tue, 27 Oct 2015 15:42:49 +0000 (16:42 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 2 Nov 2015 22:37:46 +0000 (23:37 +0100)
I don't see a way for auth->authorizer to be NULL in
ceph_x_sign_message() or ceph_x_check_message_signature().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
net/ceph/auth_x.c

index 65054fd31b97f390207e03f284d32019d49b41bb..3a544ca6b5ced9f1ca062b785c2924d4beb68ebb 100644 (file)
@@ -697,8 +697,7 @@ static int ceph_x_sign_message(struct ceph_auth_handshake *auth,
                               struct ceph_msg *msg)
 {
        int ret;
-       if (!auth->authorizer)
-               return 0;
+
        ret = calcu_signature((struct ceph_x_authorizer *)auth->authorizer,
                              msg, &msg->footer.sig);
        if (ret < 0)
@@ -713,8 +712,6 @@ static int ceph_x_check_message_signature(struct ceph_auth_handshake *auth,
        __le64 sig_check;
        int ret;
 
-       if (!auth->authorizer)
-               return 0;
        ret = calcu_signature((struct ceph_x_authorizer *)auth->authorizer,
                              msg, &sig_check);
        if (ret < 0)