[media] rc: img-ir: jvc: Remove unused no-leader timings
authorJames Hogan <james.hogan@imgtec.com>
Thu, 13 Mar 2014 10:29:23 +0000 (07:29 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 14 Mar 2014 12:49:20 +0000 (09:49 -0300)
The JVC timings included timings intended for the secondary decoder
(which matches messages with no leader), however they were in the wrong
part of the timings structure, repeating s00 and s01 rather than being
in s10 and s11.

Distinct repeat timings can't be properly supported yet for JVC anyway
since the scancode callback cannot determine which decoder matched the
message, so for now remove these timings and don't bother to enable the
secondary decoder.

This fixes the following warnings with W=1:
drivers/media/rc/img-ir/img-ir-jvc.c +76 :3: warning: initialized field overwritten [-Woverride-init]
drivers/media/rc/img-ir/img-ir-jvc.c +76 :3: warning: (near initialization for ‘img_ir_jvc.timings.s00’) [-Woverride-init]
drivers/media/rc/img-ir/img-ir-jvc.c +81 :3: warning: initialized field overwritten [-Woverride-init]
drivers/media/rc/img-ir/img-ir-jvc.c +81 :3: warning: (near initialization for ‘img_ir_jvc.timings.s01’) [-Woverride-init]

Reported-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/rc/img-ir/img-ir-jvc.c

index ae55867f6c5cd9266a82523d68f048298ed681de..10209d200efb58c7046eb58c1effef88f49a9c4b 100644 (file)
@@ -49,7 +49,6 @@ struct img_ir_decoder img_ir_jvc = {
        .control = {
                .decoden = 1,
                .code_type = IMG_IR_CODETYPE_PULSEDIST,
-               .decodend2 = 1,
        },
        /* main timings */
        .unit = 527500, /* 527.5 us */
@@ -69,16 +68,6 @@ struct img_ir_decoder img_ir_jvc = {
                        .pulse = { 1    /* 527.5 us +-60 us */ },
                        .space = { 3    /* 1.5825 ms +-40 us */ },
                },
-               /* 0 symbol (no leader) */
-               .s00 = {
-                       .pulse = { 1    /* 527.5 us +-60 us */ },
-                       .space = { 1    /* 527.5 us */ },
-               },
-               /* 1 symbol (no leader) */
-               .s01 = {
-                       .pulse = { 1    /* 527.5 us +-60 us */ },
-                       .space = { 3    /* 1.5825 ms +-40 us */ },
-               },
                /* free time */
                .ft = {
                        .minlen = 16,