usb: hsotg: samsung: Protect the udc_stop routine with spinlock
authorLukasz Majewski <l.majewski@samsung.com>
Thu, 14 Jun 2012 08:02:25 +0000 (10:02 +0200)
committerFelipe Balbi <balbi@ti.com>
Fri, 15 Jun 2012 11:37:50 +0000 (14:37 +0300)
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/s3c-hsotg.c

index b10791282f15d4dda88a4f1a52770bfbef33ddd0..ee1fe2b8b07f6e52495fd8b3d5db9a3068fd748e 100644 (file)
@@ -2988,6 +2988,7 @@ static int s3c_hsotg_udc_stop(struct usb_gadget *gadget,
                          struct usb_gadget_driver *driver)
 {
        struct s3c_hsotg *hsotg = to_hsotg(gadget);
+       unsigned long flags = 0;
        int ep;
 
        if (!hsotg)
@@ -3000,6 +3001,8 @@ static int s3c_hsotg_udc_stop(struct usb_gadget *gadget,
        for (ep = 0; ep < hsotg->num_of_eps; ep++)
                s3c_hsotg_ep_disable(&hsotg->eps[ep].ep);
 
+       spin_lock_irqsave(&hsotg->lock, flags);
+
        s3c_hsotg_phy_disable(hsotg);
        regulator_bulk_disable(ARRAY_SIZE(hsotg->supplies), hsotg->supplies);
 
@@ -3007,6 +3010,8 @@ static int s3c_hsotg_udc_stop(struct usb_gadget *gadget,
        hsotg->gadget.speed = USB_SPEED_UNKNOWN;
        hsotg->gadget.dev.driver = NULL;
 
+       spin_unlock_irqrestore(&hsotg->lock, flags);
+
        dev_info(hsotg->dev, "unregistered gadget driver '%s'\n",
                 driver->driver.name);