drm/panel: simple: Check against num_timings when setting preferred for timing
authorChen-Yu Tsai <wens@csie.org>
Mon, 24 Oct 2016 13:21:15 +0000 (21:21 +0800)
committerThierry Reding <treding@nvidia.com>
Tue, 6 Dec 2016 15:47:07 +0000 (16:47 +0100)
In the loop on .timings, we should check .num_timings to see if it's the
only mode specified, not .num_modes, which should be used with .modes.

Fixes: cda553725c92 ("drm/panel: simple: Set appropriate mode type")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/panel/panel-simple.c

index 261b0083ba4098f0fda0d10c999e82a4466b2ab4..d545834e5d2c47d08555aa146995aee326ea0696 100644 (file)
@@ -120,7 +120,7 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
 
                mode->type |= DRM_MODE_TYPE_DRIVER;
 
-               if (panel->desc->num_modes == 1)
+               if (panel->desc->num_timings == 1)
                        mode->type |= DRM_MODE_TYPE_PREFERRED;
 
                drm_mode_probed_add(connector, mode);