drm/i915/execlists: Reduce list_for_each_safe+list_safe_reset_next
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 2 Jan 2018 15:12:27 +0000 (15:12 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 3 Jan 2018 12:09:46 +0000 (12:09 +0000)
After staring at the list_for_each_safe macros for a bit, our current
invocation of list_safe_reset_next in execlists_schedule() simply
reduces to list_for_each.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: MichaƂ Winiarski <michal.winiarski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180102151235.3949-11-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_lrc.c

index 7d1ce21fa051e5cc84a5351b582659df152c9cb3..4e150b095a117d262a5cf1aae2c58b68f37aa678 100644 (file)
@@ -1029,7 +1029,7 @@ static void execlists_schedule(struct drm_i915_gem_request *request, int prio)
         * end result is a topological list of requests in reverse order, the
         * last element in the list is the request we must execute first.
         */
-       list_for_each_entry_safe(dep, p, &dfs, dfs_link) {
+       list_for_each_entry(dep, &dfs, dfs_link) {
                struct i915_priotree *pt = dep->signaler;
 
                /*
@@ -1048,8 +1048,6 @@ static void execlists_schedule(struct drm_i915_gem_request *request, int prio)
                        if (prio > READ_ONCE(p->signaler->priority))
                                list_move_tail(&p->dfs_link, &dfs);
                }
-
-               list_safe_reset_next(dep, p, dfs_link);
        }
 
        /*