aio: fix kioctx leak introduced by "aio: Fix a trinity splat"
authorBenjamin LaHaise <bcrl@kvack.org>
Sat, 21 Dec 2013 20:49:28 +0000 (15:49 -0500)
committerBenjamin LaHaise <bcrl@kvack.org>
Sat, 21 Dec 2013 20:57:09 +0000 (15:57 -0500)
e34ecee2ae791df674dfb466ce40692ca6218e43 reworked the percpu reference
counting to correct a bug trinity found.  Unfortunately, the change lead
to kioctxes being leaked because there was no final reference count to
put.  Add that reference count back in to fix things.

Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
Cc: stable@vger.kernel.org
fs/aio.c

index 6efb7f6cb22e9ba5aabb5f111129ef69b7dac370..fd1c0baf15bb529a9d62ae7edd6b676fe61f4b92 100644 (file)
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -652,7 +652,8 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
        aio_nr += ctx->max_reqs;
        spin_unlock(&aio_nr_lock);
 
-       percpu_ref_get(&ctx->users); /* io_setup() will drop this ref */
+       percpu_ref_get(&ctx->users);    /* io_setup() will drop this ref */
+       percpu_ref_get(&ctx->reqs);     /* free_ioctx_users() will drop this */
 
        err = ioctx_add_table(ctx, mm);
        if (err)